[CI][Benchmarks] Refactor Compute Runtime builds #19303
Draft
+603
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: If the only thing that changes is Compute Runtime, we don't have to rebuild all of dependencies. Perhaps there are some other situations that could limit the harsh clean rebuild criteria. |
PatKamin
force-pushed
the
compute-runtime-build
branch
2 times, most recently
from
845bb14 to
5c3127a
Compare
PatKamin
force-pushed
the
compute-runtime-build
branch
from
5c3127a to
010de94
Compare
PatKamin
force-pushed
the
compute-runtime-build
branch
2 times, most recently
from
d1a5918 to
1953df4
Compare
|
Rebased, ready for review |
- don't rebuild any of the Compute Runtime components if none of them has changed - rebuild Compute Runtime and its components if needed - refactor components directories' names to be more consistent - overall refactor the compute_runtime module
It is already implemented in all Suite subclasses. Add a type hint with a None return value. Fix the return value of setup() in a UMF suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #19158Please, review only the last commit