[SYCL][Tests] Add more syclbin-dump tests

[dm-vodopyanov]

No description provided.

[dm-vodopyanov]

Removed as it was not used and it was affecting the code coverage

[steffenlarsen]

Should we move this to an Inputs subfolder?

[steffenlarsen]

Overall I think this looks good!

[steffenlarsen]

I think it would be fine to have this in sycl/test instead.

[dm-vodopyanov]

Let's try, should work. Still investigating though why it doesn't work in CI - as it works locally. The binary now in the install folder, but still it didn't fix the issue, probably need to add to some other place in CMake files.

[dm-vodopyanov]

The only reason I see not putting it to sycl/test folder is that the test has a dependency on NEO - especially on ocloc binary, and sycl/test tests should be device-agnostic (no backend runtimes should be present in the environment)

[steffenlarsen]

Hmm, good point. Should it have //REQUIRES: ocloc?

[steffenlarsen]

Let's try, should work. Still investigating though why it doesn't work in CI - as it works locally. The binary now in the install folder, but still it didn't fix the issue, probably need to add to some other place in CMake files.

Maybe we need to do something like in https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/lit.cfg.py#L627?

[dm-vodopyanov]

Let's try, should work. Still investigating though why it doesn't work in CI - as it works locally. The binary now in the install folder, but still it didn't fix the issue, probably need to add to some other place in CMake files.

Maybe we need to do something like in https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/lit.cfg.py#L627?

Thanks! It works now :)

[dm-vodopyanov]

Failed Tests (1):
SYCL :: Reduction/reduction_nd_lambda.cpp - not related to this patch - #19354

[sarnex]

@dm-vodopyanov New failures in postcommit:

 Testing:  0.. 10.. 20.. 30..
FAIL: SYCL :: syclbin/input_files.cpp (726 of 1815)
******************** TEST 'SYCL :: syclbin/input_files.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
not syclbin-dump nonexistent.syclbin 2>&1 | FileCheck /__w/llvm/llvm/src/sycl/test/syclbin/input_files.cpp --check-prefix CHECK-NONEXISTENT-FILE
# executed command: not syclbin-dump nonexistent.syclbin
# note: command had no output on stdout or stderr
# executed command: FileCheck /__w/llvm/llvm/src/sycl/test/syclbin/input_files.cpp --check-prefix CHECK-NONEXISTENT-FILE
# note: command had no output on stdout or stderr
# RUN: at line 2
not syclbin-dump /__w/llvm/llvm/src/sycl/test/syclbin/Inputs/malformed.syclbin 2>&1 | FileCheck /__w/llvm/llvm/src/sycl/test/syclbin/input_files.cpp --check-prefix CHECK-MALFORMED-FILE
# executed command: not syclbin-dump /__w/llvm/llvm/src/sycl/test/syclbin/Inputs/malformed.syclbin
# note: command had no output on stdout or stderr
# executed command: FileCheck /__w/llvm/llvm/src/sycl/test/syclbin/input_files.cpp --check-prefix CHECK-MALFORMED-FILE
# .---command stderr------------
# | /__w/llvm/llvm/src/sycl/test/syclbin/input_files.cpp:5:26: error: CHECK-MALFORMED-FILE: expected string not found in input
# | // CHECK-MALFORMED-FILE: Invalid data was encountered while parsing the file
# |                          ^
# | <stdin>:1:1: note: scanning from here
# | Failed to parse SYCLBIN file.
# | ^
# | 
# | Input file: <stdin>
# | Check file: /__w/llvm/llvm/src/sycl/test/syclbin/input_files.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |          1: Failed to parse SYCLBIN file. 
# | check:5     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1
 ********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  SYCL :: syclbin/input_files.cpp

Can you please fix ASAP or revert? Thx

[sarnex]

@dm-vodopyanov Can you please comment on your plans to address the postcommit failures? Otherwise I will revert this PR

FYI @intel/llvm-gatekeepers

[uditagarwal97]

@dm-vodopyanov Can you please comment on your plans to address the postcommit failures? Otherwise I will revert this PR

FYI @intel/llvm-gatekeepers

Should we disable the test for now, and @dm-vodopyanov can re-enable it after fixing?

[sarnex]

Sure, will do