Skip to content

[SYCL] Disable imf libdevice for NV and AMD backend. #19190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 9, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jun 27, 2025

imf libdevice shouldn't be used by NV and AMD backend, this PR stops building it for these 2 backends.
We also move all imf e2e test cases in a separate directory following exp tests.

imf libdevice shouldn't be used by NV and AMD backend,
this PR stops building it for these 2 backends.
We also move all imf e2e test cases in a separate directory
following exp tests.

Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 requested a review from a team as a code owner June 27, 2025 05:47
@jinge90 jinge90 requested review from sergey-semenov and npmiller and removed request for sergey-semenov June 27, 2025 05:47
@jinge90 jinge90 temporarily deployed to WindowsCILock June 27, 2025 05:47 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jun 27, 2025

Hi, @npmiller
Could you take a look at this PR?
Thanks very much.

@bader
Copy link
Contributor

bader commented Jun 27, 2025

@jinge90, I just merged #19000, which disables e2e tests. Please, update your PR.

Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 temporarily deployed to WindowsCILock June 27, 2025 06:35 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jun 27, 2025

@jinge90, I just merged #19000, which disables e2e tests. Please, update your PR.

Done.
Thanks very much.

Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for cleaning that up!

@jinge90 jinge90 temporarily deployed to WindowsCILock July 2, 2025 09:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 2, 2025 09:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 4, 2025 02:30 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 4, 2025 02:51 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 4, 2025 02:51 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 7, 2025 01:35 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 7, 2025 01:56 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 7, 2025 01:56 — with GitHub Actions Inactive
@bader bader requested a review from Maetveis July 7, 2025 03:57
@jinge90 jinge90 temporarily deployed to WindowsCILock July 8, 2025 05:00 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 8, 2025 05:23 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 8, 2025 05:23 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from Maetveis July 8, 2025 07:52
Copy link
Contributor

@Maetveis Maetveis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bader
Copy link
Contributor

bader commented Jul 8, 2025

@intel/llvm-reviewers-runtime, ping.

@jinge90 jinge90 temporarily deployed to WindowsCILock July 9, 2025 00:42 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 9, 2025 01:03 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 9, 2025 01:03 — with GitHub Actions Inactive
@bader bader merged commit 0260118 into intel:sycl Jul 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants