[SYCL][Graph] Fix E2E test problems with preview/build-only mode #19178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Jun 26, 2025
Bensuo
commented
- Fix incorrect REQUIRE in NativeCommand/invalid.cpp causing issues in build-only mode
- Fix setting dynamic parameter args in preview mode not passing the raw impl ptr
- Fix incorrect REQUIRE in NativeCommand/invalid.cpp - Fix setting dynamic parameter args in preview mode not passing the raw impl ptr
EwanC
approved these changes
Jun 26, 2025
Co-authored-by: Ewan Crawford <[email protected]>
|
Ping @intel/llvm-reviewers-runtime would appreciate a review on this, thanks! |
|
|
||
| // XFAIL: preview-mode | ||
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/18911 | ||
| // REQUIRES: target-nvidia, cuda_dev_kit |
There was a problem hiding this comment.
Do we really need cuda_dev_kit feature for this test? I don't see CUDA SDK headers/library being used in this test.
Also, just out of curiosity, what's the difference between REQUIRES: target-nvidia vs. REQUIRES: cuda LIT feature? IIRC, we no longer support targeting NVidia GPUs via HIP/ROCm, so REQUIRES: target-nvidia and REQUIRES: cuda should be identical?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.