[UR][OpenCL] Refactor UR OpenCL reference counting #19176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
refCountRefactorOpenCL
branch
from
72564ef to
bbed9a0
Compare
martygrant
force-pushed
the
refCountRefactorOpenCL
branch
from
bbed9a0 to
969d2c0
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
refCountRefactorOpenCL
branch
from
969d2c0 to
8d75566
Compare
…to inherit common reference counting functionality. Update L0 and L0V2 to use this.
…r can start ref count from 0
…to any relevant handles that need ref counting.
…espace. Add a constructor for the class with a default value and remove use of reset() inside the Adapter constructor, using the RefCount constructor to set default value instead.
…nd decrementAndTest -> release, and remove decrement as it doesn't get used.
martygrant
force-pushed
the
refCountRefactorOpenCL
branch
from
7d2268a to
573ac1d
Compare
RossBrunton
reviewed
Jul 3, 2025
Bensuo
approved these changes
Jul 3, 2025
RossBrunton
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #18644
Most UR adapters had their own reference counting of some sort. This adds a new
RefCountclass and refactors adapter code so all adapters can share the same code for reference counting. This PR handles OpenCL and I will open more PRs for each adapter in turn.