Skip to content

[libspirv] Delete clc_* files in generic math and re-use clc #19165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wenju-he
Copy link
Contributor

llvm-diff shows a lot of changes, including

  • __nv_ldexp and __nvvm_reflect_ocl calls are newly added __spirv_ocl_remquo/tanpi in libspirv-nvptx64--nvidiacl.bc.
  • __ocml_ldexp_f64 is replaced with llvm.ldexp.f64.i32 in __spirv_ocl_remquo in libspirv-amdgcn--amdhsa.bc.
    The changes look reasonable since some functions are replaced with clc implementations.

llvm-diff shows a lot of changes, including
* __nv_ldexp and __nvvm_reflect_ocl calls are newly added
  __spirv_ocl_remquo/tanpi in libspirv-nvptx64--nvidiacl.bc.
* __ocml_ldexp_f64 is replaced with llvm.ldexp.f64.i32 in
  __spirv_ocl_remquo in libspirv-amdgcn--amdhsa.bc.
The changes look reasonable since some functions are replaced with clc
implementations.
@wenju-he wenju-he requested a review from a team as a code owner June 26, 2025 07:56
@wenju-he wenju-he requested a review from steffenlarsen June 26, 2025 07:56
@wenju-he
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge, thanks

@steffenlarsen steffenlarsen merged commit 7189d82 into intel:sycl Jun 27, 2025
37 of 39 checks passed
@wenju-he wenju-he deleted the libspirv-generic-math-clc-cleanup branch June 27, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants