Skip to content

Conversation

@keyradical
Copy link
Contributor

@keyradical keyradical commented Jun 18, 2025

Creates new file structure of Graph code. In the public headers it'll now be:

├── graph
│   ├── command_graph.hpp
│   ├── executable_graph.hpp
│   ├── dynamic.hpp
│   ├── node.hpp
│   └── modifiable_graph.hpp
├── graph.hpp

where graph.hpp just contains the includes of the remaining headers in graph/.

Inside the impl section, source/detail it'll be:

├── graph
│   ├── dynamic_impl.cpp
│   ├── dynamic_impl.hpp
│   ├── graph_impl.cpp
│   ├── graph_impl.hpp
│   ├── memory_pool.cpp
│   ├── memory_pool.hpp
│   ├── node_impl.cpp
│   └── node_impl.hpp

The includes in all files have been updated such that forward declarations are favoured wherever possible.

@keyradical keyradical force-pushed the konrad/RefactorGraphHeaders branch 3 times, most recently from 559ada9 to 1eca2fc Compare June 19, 2025 20:12
@keyradical keyradical marked this pull request as ready for review June 19, 2025 20:53
@keyradical keyradical requested review from a team as code owners June 19, 2025 20:53
@keyradical keyradical requested a review from a team as a code owner June 23, 2025 08:08
@keyradical keyradical force-pushed the konrad/RefactorGraphHeaders branch from 736dd22 to 2439ca4 Compare June 23, 2025 08:37
@keyradical keyradical force-pushed the konrad/RefactorGraphHeaders branch from 2439ca4 to 438bd63 Compare June 23, 2025 08:48
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devops changes LGTM.

@uditagarwal97 uditagarwal97 requested a review from a team June 23, 2025 14:55
@keyradical keyradical force-pushed the konrad/RefactorGraphHeaders branch from e0f384b to 3f7a911 Compare June 23, 2025 17:01
@keyradical keyradical force-pushed the konrad/RefactorGraphHeaders branch from ee094b8 to dc48d70 Compare June 25, 2025 14:00
@keyradical
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready to merge. Thanks

@aelovikov-intel aelovikov-intel merged commit adf3592 into intel:sycl Jun 25, 2025
37 of 38 checks passed
@keyradical
Copy link
Contributor Author

FYI this broke post commit windows CI but here is the fix: #19149

sarnex pushed a commit that referenced this pull request Jun 25, 2025
Fixes post-commit windows CI failure introduced by #19045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants