[SYCL][E2E] Pass sycl target options to clang in one test #18997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to ensure that the correct target with the correct options is used when linking with clang in the test. For example without trying to use the `SPIR-V` (not the SPIR) backend for testing with `--param spirv-backend=True` does not take effect. If the test would be run on a non SPIR target it would fail as clang is expecting object files for the SPIR target when `-fsycl-targets` is not set.
againull
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to ensure that the correct target with the correct options is used when linking with clang in the test. For example without trying to use the
SPIR-V(not the SPIR) backend for testing with--param spirv-backend=Truedoes not take effect. If the test would be run on a non SPIR target it would fail as clang is expecting object files for the SPIR target when-fsycl-targetsis not set.