[SYCL] Profile host events only if the submitted queue has profiling enabled #18982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng enabled Currently profiling for host tasks is tracked no matter what. Track it only if the queue, where host task is submitted, has profiling enabled.
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
Do you know if this was a bug or a case of changing requirements/design decisions?
Contributor
Author
I believe this is a bug, according to spec 4.6.6. Event class:
Also this can be considered as performance bug as well. |
aelovikov-intel
approved these changes
Jun 17, 2025
Contributor
Author
|
syclcompat/kernel/kernel_win.cpp failure is unrelated and known: #17561 |
uditagarwal97
pushed a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently profiling for host tasks is always enabled. Track profiling info only if the submitted queue (where host task is submitted) has profiling enabled.
This is a bug, according to SYCL specification 4.6.6. Event class:
"Calls to get_profiling_info must throw an exception with the errc::invalid error code if the SYCL queue which submitted the command group this SYCL event is associated with was not constructed with the property::queue::enable_profiling property."
This can be considered as performance bug as well.