Skip to content

Cast Integer to enumeration type using static_cast for KernelNameType #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2020
Merged

Cast Integer to enumeration type using static_cast for KernelNameType #1895

merged 3 commits into from
Jun 17, 2020

Conversation

@srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Jun 15, 2020 •
edited
Loading

For specializations of KernelInfo for kernel function types, cast Integer to Enumeration type using static_cast.
Eg: template <> struct KernelInfo<::dummy_functor_1<(no_namespace_int)0>> to
template <> struct KernelInfo<::dummy_functor_1<static_cast<no_namespace_int>(0)>>
Issue# : #1784

@srividya-sundaram
[SYCL]Cast Integer to Enumeration Type using static_cast for Kernels …
a82639f 
…defined as templated function object where the template parameter is of enum type (scoped and unscoped).

Eg: template <> struct KernelInfo<::dummy_functor_1<(no_namespace_int)0>> to
template <> struct KernelInfo<::dummy_functor_1<static_cast<no_namespace_int>(0)>>
@srividya-sundaram
Merge branch 'sycl' of https://github.com/intel/llvm into KernelNameT…
0cfffc4 
…ype_static_cast
@srividya-sundaram
clang-format fix
6644df3
premanandrao
premanandrao approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elizabethandrews
Copy link
Contributor

elizabethandrews commented Jun 15, 2020

Error does not seem related to patch.

   [19/33] Performing update step for 'l0-loader'
    FAILED: tools/sycl/plugins/level_zero/l0-loader-prefix/src/l0-loader-stamp/l0-loader-update 
    cd /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64- 
    pr/llvm.obj/tools/sycl/plugins/level_zero/Level0/l0_loader && /usr/local/bin/cmake -P 
    /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.obj/tools/sycl/plugins/level_zero/l0- 
    loader-prefix/tmp/l0-loader-gitupdate.cmake
    fatal: unable to access 'https://github.com/oneapi-src/level-zero.git/': Couldn't connect to 
    server
    CMake Error at /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64- 
    pr/llvm.obj/tools/sycl/plugins/level_zero/l0-loader-prefix/tmp/l0-loader-gitupdate.cmake:55 
    (message):
    Failed to fetch repository 'https://github.com/oneapi-src/level-zero.git'

@bader is this a known issue?

@bader
Copy link
Contributor

bader commented Jun 15, 2020

+@againull

@Fznamznon
Copy link
Contributor

Fznamznon commented Jun 15, 2020

Could you please follow these guidelines when writing commit message in the future? https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

@srividya-sundaram
Copy link
Contributor Author

srividya-sundaram commented Jun 16, 2020

Tried rebuilding the failed check and got : Cannot rebuild: you need to have role 'llvm-write'
Can someone add me to that role?

@elizabethandrews
Copy link
Contributor

elizabethandrews commented Jun 16, 2020

Oh strange. I don't think I have write access too but I am able to rebuild. Can you make sure you are signed in? Top right corner will say 'Anonymous' if you are not signed in. Maybe that is issue?

@srividya-sundaram
Copy link
Contributor Author

srividya-sundaram commented Jun 16, 2020

Thanks. I had to authorize bb-sycl to access my github account.

@againull
Copy link
Contributor

againull commented Jun 16, 2020 •
edited
Loading

+@againull

This looks like CI issue to me:

fatal: unable to access 'https://github.com/oneapi-src/level-zero.git/': Couldn't connect to 
    server

Please report such errors to the CI team.

@bader bader merged commit ebefb26 into sycl Jun 17, 2020
@bader bader deleted the KernelNameType_static_cast branch June 17, 2020 10:26
bb-sycl pushed a commit that referenced this pull request Apr 4, 2023
@vmaksimo @againull
Translate annotation string with the braces for UserSemantic decorati…
1c3f610 
…on (#1895)

Decoration's handling is done alike to other decorations. However, we
should preserve the braces so we save the input string after reverse
translation.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@84e48b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fznamznon Fznamznon Fznamznon approved these changes

@premanandrao premanandrao premanandrao approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@srividya-sundaram @elizabethandrews @bader @Fznamznon @againull @premanandrao