[SYCL] protect against possible data corruption cause by std::locale side effect #18578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-effect, causing numbers (include hex) to be formatted with commas and periods where we might not expect such. In most cases, our use of std streams is for user facing messages. But in some cases they are used in places where formatting could cause errors. This PR attempts to shore these places up. Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Seems like this would impact #18561 as well? |
ProGTX
approved these changes
May 21, 2025
|
@ProGTX - I'm guessing yes. If you output numbers onto a stream, then you are at risk for the localization side effect. Use .imbue() to prevent that. |
|
@uditagarwal97 - I have a related fix with test over here: #18550 |
The test in #18550 is good enough for me - it demonstrates the original issue with using std::locale |
uditagarwal97
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::locale::global() in a user app can impact the SYCL library by side-effect, causing numbers (include hex) to be formatted with commas and periods where we might not expect such. In most cases, our use of std streams is for user facing messages. But in some cases they are used in places where unexpected formatting could cause errors. This PR attempts to shore these places up.