LLVM and SPIRV-LLVM-Translator pulldown #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's going to fail FunctionInfo lookup anyway.
This patch addresses the comment in [D80972](https://reviews.llvm.org/D80972#inline-744217). Before this patch, the initial length field of .debug_aranges section should be declared as: ``` ## 32-bit DWARF debug_aranges: - Length: TotalLength: 0x20 Version: 2 ... ## 64-bit DWARF debug_aranges: - Length: TotalLength: 0xffffffff TotalLength64: 0x20 Version: 2 ... ``` After this patch: ``` ## 32-bit DWARF debug_aranges: - [[Format: DWARF32]] ## Optional Length: 0x20 Version: 2 ... ## 64-bit DWARF debug_aranges: - Format: DWARF64 Length: 0x20 Version: 2 ``` Current implementation of generating DWARF64 .debug_aranges section is buggy. A follow-up patch will improve it and add test cases for DWARF64. Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D81063
This reverts commit 9bdb918. This refactoring proved to not be useful.
Also assign OptInFFlag and OptOutFFlag to f_Group.
…r is" This reverts commit c57f8a3.
…sure type" This reverts commit c13dd74.
…of padding Update linalg to affine lowering for convop to use affine load for input whenever there is no padding. It had always been using std.loads because max in index functions (needed for non-zero padding if not materializing zeros) couldn't be represented in the non-zero padding cases. In the future, the non-zero padding case could also be made to use affine - either by materializing or using affine.execute_region. The latter approach will not impact the scf/std output obtained after lowering out affine. Differential Revision: https://reviews.llvm.org/D81191
Summary: Add AND/OR/XOR regression tests and separate bit-op tests from exisiting tests. Differential Revision: https://reviews.llvm.org/D81206
Summary: A followup of D79938. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D81066
After a180d54 the build was failing with: In file included from /work/llvm.monorepo/clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:9:0: /work/llvm.monorepo/clang/unittests/ASTMatchers/ASTMatchersTest.h: In function ‘llvm::ArrayRef<clang::TestLanguage> clang::ast_matchers::langCxx11OrLater()’: /work/llvm.monorepo/clang/unittests/ASTMatchers/ASTMatchersTest.h:64:10: error: could not convert ‘(const clang::TestLanguage*)(& Result)’ from ‘const clang::TestLanguage*’ to ‘llvm::ArrayRef<clang::TestLanguage>’ return Result; ^
Differential Revision: https://reviews.llvm.org/D81194
This will later be used during canonicalization and folding steps to replace statically known passing constraints. Differential Revision: https://reviews.llvm.org/D80307
This allows assuming_all to be replaced when all inputs are known to be statically passing witnesses. Differential Revision: https://reviews.llvm.org/D80306
If any input to shape.any is a const_shape, shape.any can be replaced with that input. Differential Revision: https://reviews.llvm.org/D80305
This allows replacing of this op with a true witness in the case of both inputs being const_shapes and being found to be broadcastable. Differential Revision: https://reviews.llvm.org/D80304
In the case of all inputs being constant and equal, cstr_eq will be replaced with a true_witness. Differential Revision: https://reviews.llvm.org/D80303
Summary: This will inline the region to a shape.assuming in the case that the input witness is found to be statically true. Differential Revision: https://reviews.llvm.org/D80302
Use getMemoryOpCost from the generic implementation of getUserCost and have getInstructionThroughput return the result of that for loads and stores. This also means that the X86 implementation of getUserCost can be removed with the functionality folded into its getMemoryOpCost. Differential Revision: https://reviews.llvm.org/D80984
Summary: This patch upstreams support for a new storage only bfloat16 C type. This type is used to implement primitive support for bfloat16 data, in line with the Bfloat16 extension of the Armv8.6-a architecture, as detailed here: https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/posts/arm-architecture-developments-armv8-6-a The bfloat type, and its properties are specified in the Arm Architecture Reference Manual: https://developer.arm.com/docs/ddi0487/latest/arm-architecture-reference-manual-armv8-for-armv8-a-architecture-profile In detail this patch: - introduces an opaque, storage-only C-type __bf16, which introduces a new bfloat IR type. This is part of a patch series, starting with command-line and Bfloat16 assembly support. The subsequent patches will upstream intrinsics support for BFloat16, followed by Matrix Multiplication and the remaining Virtualization features of the armv8.6-a architecture. The following people contributed to this patch: - Luke Cheeseman - Momchil Velikov - Alexandros Lamprineas - Luke Geeson - Simon Tatham - Ties Stuij Reviewers: SjoerdMeijer, rjmccall, rsmith, liutianle, RKSimon, craig.topper, jfb, LukeGeeson, fpetrogalli Reviewed By: SjoerdMeijer Subscribers: labrinea, majnemer, asmith, dexonsmith, kristof.beyls, arphaman, danielkiss, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D76077
Add llvm_unreachable after switch statement for TestLanguage enum
…ons. NFC. Remove unnecessary MemoryAccess forward declaration as its already included from MemorySSA.h Move implicit include dependencies down to source files.
Summary: Add regression tests of asmparser, mccodeemitter, and disassembler for fixed-point operation instructions. In order to support them, we add MImm parser to asmparser. Also add a new MPD instruction which is one of multiply instructions. Differential Revision: https://reviews.llvm.org/D81207
It regressed recently by my: https://reviews.llvm.org/D81119
We don't need any of its defs or many of its includes inside PostDominators.h - so split it and reduce the frontend load.
llvm-project\clang\lib\Driver\Types.cpp(44): fatal error C1001: An internal error has occurred in the compiler. (compiler file 'msc1.cpp', line 1518)
It is quite common to get multiple instances of optimization flags while building. The following optimizations does not have cl::ZeroOrMore which causes errors during the build. Reviewers: alexbdv,spop Differential Revision: https://reviews.llvm.org/D81187
CONFLICT (content): Merge conflict in clang/lib/Driver/Types.cpp CONFLICT (content): Merge conflict in clang/lib/Driver/Driver.cpp
Extend constexprs lowering support to lower constant vector of pure function pointers w/o any transformations inside.
…tch name in SPIRVNameMapEnum.h * Add ExecutionModeSubgroupSize to SPIRVNameMapEnum.h
The behavior is still configurable via source code change Signed-off-by: Aleksander Fadeev <[email protected]>
Found*contractedFMulAdd became unused after commit e89518b ("Enable
strict rules to set ContractionOFF (intel#521)", 2020-05-20).
Add a missing override to suppress a -Winconsistent-missing-override
warning.
AlexeySachkov
requested review from
AGindinson,
AlexeySotkin,
Fznamznon,
bader,
elizabethandrews,
mdtoguchi and
premanandrao
as code owners
Contributor
|
|
This was referenced Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
76 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM: 02e3583
LLVM-SPIRV-Translator: KhronosGroup/SPIRV-LLVM-Translator@eeca450