Skip to content

[SYCL] add clang diagnostic for kernel free function #18329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 9, 2025
Merged

[SYCL] add clang diagnostic for kernel free function #18329

merged 10 commits into from
May 9, 2025

Conversation

dklochkov-emb
Copy link
Contributor

@dklochkov-emb dklochkov-emb commented May 6, 2025 •
edited
Loading

  1. Kernel free function should not support arguments with default values according to docs.
  2. Kernel free function should have return type void only, diagnostic message was added to clarify that.
    PR adds diagnostic messages for this cases.

@dklochkov-emb dklochkov-emb requested review from a team as code owners May 6, 2025 09:41
@dklochkov-emb dklochkov-emb self-assigned this May 6, 2025
@dklochkov-emb dklochkov-emb marked this pull request as draft May 6, 2025 09:48
steffenlarsen
steffenlarsen reviewed May 6, 2025
View reviewed changes
@dklochkov-emb dklochkov-emb changed the title [SYCL] add clang diagnostic for kernel free function with default argument value [SYCL] add clang diagnostic for kernel free function May 6, 2025
@dklochkov-emb dklochkov-emb marked this pull request as ready for review May 6, 2025 14:14
Fznamznon
Fznamznon reviewed May 6, 2025
View reviewed changes
@dklochkov-emb dklochkov-emb requested a review from Fznamznon May 7, 2025 09:04
Fznamznon
Fznamznon reviewed May 7, 2025
View reviewed changes
steffenlarsen
steffenlarsen approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fznamznon
Fznamznon reviewed May 7, 2025
View reviewed changes
@dklochkov-emb
Copy link
Contributor Author

@intel/llvm-gatekeepers Please, merge it.

@martygrant martygrant merged commit 5512617 into intel:sycl May 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fznamznon Fznamznon Fznamznon approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees

@dklochkov-emb dklochkov-emb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dklochkov-emb @Fznamznon @steffenlarsen @martygrant