Skip to content

[SYCL] Addrspacecast needed even in non-alloca sret #18224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Draft

[SYCL] Addrspacecast needed even in non-alloca sret #18224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions clang/lib/CodeGen/CGCall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5346,13 +5346,14 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo,
// chosen IndirectAS can happen e.g. when passing the this pointer through
// a chain involving stores to / loads from the DefaultAS; we address this
// here, symmetrically with the handling we have for normal pointer args.
if (CGM.getCodeGenOpts().UseAllocaASForSrets &&
(SRetPtr.getAddressSpace() != RetAI.getIndirectAddrSpace())) {
unsigned RetAddrSpace = CGM.getCodeGenOpts().UseAllocaASForSrets
? RetAI.getIndirectAddrSpace()
: CGM.getTypes().getTargetAddressSpace(RetTy);
if (SRetPtr.getAddressSpace() != RetAddrSpace) {
llvm::Value *V = SRetPtr.getBasePointer();
LangAS SAS = getLangASFromTargetAS(SRetPtr.getAddressSpace());
LangAS DAS = getLangASFromTargetAS(RetAI.getIndirectAddrSpace());
llvm::Type *Ty = llvm::PointerType::get(getLLVMContext(),
RetAI.getIndirectAddrSpace());
LangAS DAS = getLangASFromTargetAS(RetAddrSpace);
llvm::Type *Ty = llvm::PointerType::get(getLLVMContext(), RetAddrSpace);

SRetPtr = SRetPtr.withPointer(
getTargetHooks().performAddrSpaceCast(*this, V, SAS, DAS, Ty, true),
Expand Down