Skip to content

[SYCL][Graph] Remove explicit L0 wait from SYCL-RT #18064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

[SYCL][Graph] Remove explicit L0 wait from SYCL-RT #18064

merged 4 commits into from
Apr 17, 2025

Conversation

@keyradical
Copy link
Contributor

@keyradical keyradical commented Apr 16, 2025 •
edited
Loading

This PR:

  • Removes explicit L0 event wait from SYCL-RT and moves it to the Command buffer at UR level,
  • Removes dead code from exec_graph_impl::enqueue().

Fixes #17734

@keyradical keyradical requested a review from a team as a code owner April 16, 2025 17:19
@keyradical keyradical requested a review from fabiomestre April 16, 2025 17:19
@keyradical keyradical force-pushed the konrad/moveL0SimultaneousGraphSync branch from 0a987d9 to 23dc3b7 Compare April 16, 2025 17:31
Bensuo
Bensuo reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but LGTM otherwise!

@keyradical
Copy link
Contributor Author

keyradical commented Apr 17, 2025

@intel/llvm-gatekeepers could you merge this, please?

@sarnex sarnex merged commit 877beee into intel:sycl Apr 17, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiomestre fabiomestre Awaiting requested review from fabiomestre fabiomestre is a code owner automatically assigned from intel/sycl-graphs-reviewers

1 more reviewer

@Bensuo Bensuo Bensuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SYCL][UR][Graph] Move L0 simultaneous graph synchronization from SYCL-RT to L0 adapter

3 participants

@keyradical @Bensuo @sarnex