Skip to content

[SYCL] Fix move instead of copy Coverity hits #17982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

[SYCL] Fix move instead of copy Coverity hits #17982

merged 5 commits into from
Apr 18, 2025

Conversation

@ayylol
Copy link
Contributor

@ayylol ayylol commented Apr 11, 2025 •
edited
Loading

Move instead of copy Coverity hit fixes for sycl/source/detail/queue_impl.hpp and sycl/source/detail/scheduler/commands.cpp

@ayylol ayylol requested a review from a team as a code owner April 11, 2025 15:49
@ayylol ayylol requested a review from againull April 11, 2025 15:49
@ayylol ayylol changed the title [SYCL] Fix move instead of copy hits in scheduler/commands.cpp [SYCL] Fix move instead of copy Coverity hits in scheduler/commands.cpp Apr 11, 2025
@ayylol ayylol temporarily deployed to WindowsCILock April 11, 2025 15:50 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 11, 2025 16:30 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 11, 2025 16:30 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 11, 2025 16:54 — with GitHub Actions Inactive
againull
againull reviewed Apr 11, 2025
View reviewed changes
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 17:38 — with GitHub Actions Inactive
@ayylol ayylol requested a review from againull April 14, 2025 17:39
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 18:13 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 18:22 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 18:29 — with GitHub Actions Inactive
@ayylol
Copy link
Contributor Author

ayylol commented Apr 14, 2025

@againull sorry, After your approval I noticed I missed one more move instead of copy hit, which i figure would be best to just include in this pr rather than make a new one

@ayylol ayylol changed the title [SYCL] Fix move instead of copy Coverity hits in scheduler/commands.cpp [SYCL] Fix move instead of copy Coverity hits Apr 14, 2025
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 19:06 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 19:06 — with GitHub Actions Inactive
@againull againull self-requested a review April 14, 2025 19:09
@ayylol ayylol temporarily deployed to WindowsCILock April 14, 2025 19:16 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 17, 2025 14:19 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 17, 2025 15:04 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 17, 2025 15:22 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 17, 2025 15:22 — with GitHub Actions Inactive
@againull againull merged commit 0a42cf7 into intel:sycl Apr 18, 2025
36 of 38 checks passed
KornevNikita pushed a commit that referenced this pull request May 27, 2025
@ayylol @KornevNikita
[SYCL] Fix move instead of copy Coverity hits (#17982)
e7f8cfe 
Move instead of copy Coverity hit fixes for
`sycl/source/detail/queue_impl.hpp` and
`sycl/source/detail/scheduler/commands.cpp`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@againull againull againull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayylol @againull