[SYCL] Fix FPGA devices selection on queue initialization #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FPGA device selectors use global constants of std::string type as parameters in constructor. If some other inline global variable uses fpga_device_selector in its constructor then there may be a situation when FPGA device selector is initialized before global std::string objects that it is depending on. Then it cannot find FPGA hw or emulator devices because it has uninitialized platform name member. Change type of constant strings with platform names to constant C-string to guarantee initialization of FPGA device selector with proper platform name.
alexbatashev
previously approved these changes
Jun 1, 2020
v-klochkov
reviewed
Jun 1, 2020
v-klochkov
reviewed
Jun 1, 2020
alexbatashev
approved these changes
Jun 2, 2020
MrSidims
approved these changes
Jun 2, 2020
mlychkov
deleted the
private/mlychkov/fix_global_initialization_of_fpga_device_selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FPGA device selectors use global constants of std::string type as
parameters in constructor. If some other inline global variable uses
fpga_device_selector in its constructor then there may be a situation
when FPGA device selector is initialized before global std::string
objects that it is depending on. Then it cannot find FPGA hw or
emulator devices because it has uninitialized platform name member.
Change type of constant strings with platform names to constant
C-string to guarantee initialization of FPGA device selector with
proper platform name.