[Driver][SYCL] Fix processing when using -fsycl-link #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
previously approved these changes
May 28, 2020
Contributor
AGindinson
left a comment
AGindinson
left a comment
There was a problem hiding this comment.
LGTM.
As a follow-up idea, could we schedule more E2E tests like sycl/test/separate-compile/, including the -fsycl-link flow?
Contributor
Author
Creation of E2E testing revealed this problem, so this is covered. |
When using -fsycl-link, the expectation is for the generated object file to be able to be linked in by a non-SYCL enabled compiler/linker. The generated object did not contain the proper device binary. Fix this up to go through all of the proper steps to create the wrapped .spv. Signed-off-by: Michael D Toguchi <[email protected]>
mdtoguchi
force-pushed
the
private/mdtoguchi/fsycl-link-spirv
branch
from
3f0ed96 to
4cc0474
Compare
AGindinson
approved these changes
May 30, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 2, 2020
* upstream/sycl: [SYCL] Handle KernelName templated using type with enum template argument (intel#1780) [SYCL] Fix KernelNameInfo generated for empty template parameter pack (intel#1775) [SYCL] Do not export utility methods from SYCLMemObjT (intel#1768) [Driver][SYCL] Fix processing when using -fsycl-link (intel#1765) [SYCL][NFC] Remove outdated confusing comment (intel#1779) [SYCL][NFC] Wrap classes in .cpp into a namespace to disable external linkage. (intel#1776) [SYCL][CUDA] Fixes CUDA unit tests that uses SYCL directly (intel#1763) [SYCL][Doc] Fix default device selection rules doc (intel#1769) [SYCL][CUDA] Remove pi Event Callback implementation (intel#1735) [SYCL] Throw exception if range/offset of kernel execution exceeds INT_MAX (intel#1713) [SYCL-PTX] Add intermediate layer to libclc to ease type management (intel#1712)
Fznamznon
pushed a commit
to Fznamznon/llvm
that referenced
this pull request
Dec 14, 2022
The ptr_annotation/var_annotation/annotation intrinsics gained additional overloads which means we have to update calls to Intrinsic::getDeclaration()/Builder.CreateIntrinsic(). Original commit: KhronosGroup/SPIRV-LLVM-Translator@41d2056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using -fsycl-link, the expectation is for the generated object file
to be able to be linked in by a non-SYCL enabled compiler/linker. The
generated object did not contain the proper device binary. Fix this up
to go through all of the proper steps to create the wrapped .spv.
Signed-off-by: Michael D Toguchi [email protected]