[SYCL][NFC] Cleanup SYCL RT CMakeLists [1/N] #17387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one patch in a series intended to re-organize `add_sycl_rt_library` helper function to make it shorter and simpler. Cleaned up `add_dependencies` calls: - UR adapters are linked with UMF, there is an implicit dependency already - `LIB_OBJ_NAME` is an `OBJECT` library, it is not linked to anything and therefore should not have any dependencies except for header files Ideally, we should not have any `add_dependencies` calls, but due to dynamic loading mechanisms used everywhere, we need those dependencies set explicitly to ensure that everything is re-built correctly.
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
reviewed
Mar 11, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Mar 11, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one patch in a series intended to re-organize
add_sycl_rt_libraryhelper function to make it shorter and simpler.Cleaned up
add_dependenciescalls:LIB_OBJ_NAMEis anOBJECTlibrary, it is not linked to anything and therefore should not have any dependencies except for header filesIdeally, we should not have any
add_dependenciescalls, but due to dynamic loading mechanisms used everywhere, we need those dependencies set explicitly to ensure that everything is re-built correctly.