Skip to content

[SYCL][UR][L0 v2] use blocking free when returning memory to the driver #17375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

[SYCL][UR][L0 v2] use blocking free when returning memory to the driver #17375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b9bb30
[SYCL][UR][L0 v2] make umf error handling less verbose
igchor Dec 17, 2024
e251dc9
[SYCL][UR][L0 v2] use blocking free when returning memory to the driver
igchor Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 18 additions & 26 deletions unified-runtime/source/adapters/level_zero/v2/usm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@

#include <umf/providers/provider_level_zero.h>

static inline void UMF_CALL_THROWS(umf_result_t res) {
if (res != UMF_RESULT_SUCCESS) {
throw res;
}
}

namespace umf {
ur_result_t getProviderNativeError(const char *providerName,
int32_t nativeError) {
Expand Down Expand Up @@ -99,35 +105,21 @@ descToDisjoinPoolMemType(const usm::pool_descriptor &desc) {
static umf::provider_unique_handle_t
makeProvider(usm::pool_descriptor poolDescriptor) {
umf_level_zero_memory_provider_params_handle_t hParams;
umf_result_t umf_ret = umfLevelZeroMemoryProviderParamsCreate(&hParams);
if (umf_ret != UMF_RESULT_SUCCESS) {
throw umf::umf2urResult(umf_ret);
}

UMF_CALL_THROWS(umfLevelZeroMemoryProviderParamsCreate(&hParams));
std::unique_ptr<umf_level_zero_memory_provider_params_t,
decltype(&umfLevelZeroMemoryProviderParamsDestroy)>
params(hParams, &umfLevelZeroMemoryProviderParamsDestroy);

umf_ret = umfLevelZeroMemoryProviderParamsSetContext(
hParams, poolDescriptor.hContext->getZeHandle());
if (umf_ret != UMF_RESULT_SUCCESS) {
throw umf::umf2urResult(umf_ret);
};
UMF_CALL_THROWS(umfLevelZeroMemoryProviderParamsSetContext(
hParams, poolDescriptor.hContext->getZeHandle()));

ze_device_handle_t level_zero_device_handle =
poolDescriptor.hDevice ? poolDescriptor.hDevice->ZeDevice : nullptr;

umf_ret = umfLevelZeroMemoryProviderParamsSetDevice(hParams,
level_zero_device_handle);
if (umf_ret != UMF_RESULT_SUCCESS) {
throw umf::umf2urResult(umf_ret);
}

umf_ret = umfLevelZeroMemoryProviderParamsSetMemoryType(
hParams, urToUmfMemoryType(poolDescriptor.type));
if (umf_ret != UMF_RESULT_SUCCESS) {
throw umf::umf2urResult(umf_ret);
}
UMF_CALL_THROWS(umfLevelZeroMemoryProviderParamsSetDevice(
hParams, level_zero_device_handle));
UMF_CALL_THROWS(umfLevelZeroMemoryProviderParamsSetMemoryType(
hParams, urToUmfMemoryType(poolDescriptor.type)));

std::vector<ze_device_handle_t> residentZeHandles;

Expand All @@ -140,13 +132,13 @@ makeProvider(usm::pool_descriptor poolDescriptor) {
residentZeHandles.push_back(device->ZeDevice);
}

umf_ret = umfLevelZeroMemoryProviderParamsSetResidentDevices(
hParams, residentZeHandles.data(), residentZeHandles.size());
if (umf_ret != UMF_RESULT_SUCCESS) {
throw umf::umf2urResult(umf_ret);
}
UMF_CALL_THROWS(umfLevelZeroMemoryProviderParamsSetResidentDevices(
hParams, residentZeHandles.data(), residentZeHandles.size()));
}

UMF_CALL_THROWS(umfLevelZeroMemoryProviderParamsSetFreePolicy(
hParams, UMF_LEVEL_ZERO_MEMORY_PROVIDER_FREE_POLICY_BLOCKING_FREE));

auto [ret, provider] =
umf::providerMakeUniqueFromOps(umfLevelZeroMemoryProviderOps(), hParams);
if (ret != UMF_RESULT_SUCCESS) {
Expand Down
Loading