Enable cmake argument passthrough in the SYCL configure wrapper #17189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldrumm
force-pushed
the
configure-args
branch
from
4c38686 to
b63439f
Compare
coldav
approved these changes
Feb 26, 2025
aelovikov-intel
approved these changes
Feb 26, 2025
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
- Ideally, we should drop the script and use cmake caches instead. Noone has volunteered to do that so far... ;(
- Maybe do that for
-D*only?
Contributor
Author
|
On Wed Feb 26, 2025 at 4:56 PM GMT, aelovikov-intel wrote:
@aelovikov-intel approved this pull request.
1) Ideally, we should drop the script and use cmake caches instead.
Noone has volunteered to do that so far... ;(
2) Maybe do that for `-D*` only?
Do what for `-D` only?
|
Contributor
Passthrough. |
Contributor
Author
|
I've already found the passthrough useful for other flags locally (e.g.) |
Contributor
Author
|
ping @dpcpp-doc-reviewers |
Contributor
Author
|
I can't seem to ping the docs reviewers, so (with apologies) ping @steffenlarsen |
AlexeySachkov
approved these changes
Mar 11, 2025
steffenlarsen
approved these changes
Mar 12, 2025
Hundreds of `--cmake-opt=-DFOO=BAR` on the command line make it hard to see the wood for the trees, so introduce an alternative which is to simply pass unknown argument flags straight through to cmake. This should make using the wrapper a little more pleasant and readable.
Contributor
Author
KornevNikita
pushed a commit
that referenced
this pull request
Mar 21, 2025
Hundreds of `--cmake-opt=-DFOO=BAR` on the command line make it hard to see the wood for the trees, so introduce an alternative which is to simply pass unknown argument flags straight through to cmake. This should make using the wrapper a little more pleasant and readable.
AlexeySachkov
pushed a commit
that referenced
this pull request
Mar 31, 2025
Hundreds of `--cmake-opt=-DFOO=BAR` on the command line make it hard to see the wood for the trees, so introduce an alternative which is to simply pass unknown argument flags straight through to cmake. This should make using the wrapper a little more pleasant and readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hundreds of
--cmake-opt=-DFOO=BARon the command line make it hard to see the wood for the trees, so introduce an alternative which is to simply pass unknown argument flags straight through to cmake. This should make using the wrapper a little more pleasant and readable.