[UR] Updates to source checks job #17160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/formatting
branch
from
2aa2caf to
dffdc93
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
changed the title
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/formatting
branch
from
dffdc93 to
848bd93
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
approved these changes
Feb 27, 2025
RossBrunton
force-pushed
the
ross/formatting
branch
from
848bd93 to
a23a349
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
changed the title
Contributor
Author
|
@intel/dpcpp-devops-reviewers Can I get this looked at quickly? I just updated one of the UR jobs so that it doesn't pull in a dependency it doesn't need. |
kbenzie
approved these changes
Mar 3, 2025
Contributor
Author
|
@intel/dpcpp-devops-reviewers Still need a quick look at this. |
uditagarwal97
approved these changes
Mar 11, 2025
The `check-generated` cmake target now only checks files generated from the specification. The LLVM code_formatter job is sufficient to check other files. As part of this, the source generation scripts now also run clang-format on their outputs. Generated .def files are also now considered C++ code, and formatted as well. In addition, the source checks job itself now no longer installs hwloc.
RossBrunton
force-pushed
the
ross/formatting
branch
from
a23a349 to
360edaf
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check-generatedcmake target now only checks files generatedfrom the specification. The LLVM code_formatter job is sufficient
to check other files. As part of this, the source generation
scripts now also run clang-format on their outputs. Generated .def
files are also now considered C++ code, and formatted as well.
In addition, the source checks job itself now no longer installs
hwloc.