[SYCL] Do not use entire sycl/sycl.hpp in small tests #17027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Feb 18, 2025
|
@intel/llvm-gatekeepers This is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include entire
<sycl/sycl.hpp>insycl/test/extensions/DeviceImageBackendContent/negative_test.cppUse more fine-grained includes instead. For E2E tests, this is a matter of performance, but in this case including all the SYCL headers can go as far as causing compilation issues in environments that require
c++20but whosegccdoes not fully implementc++20features.