-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL][E2E] Replace any-device-is- with target- features in %if markup
#16889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any-device-is- with target- features in %if markupany-device-is- with target- features in %if markup
any-device-is- with target- features in %if markupany-device-is- with target- features in %if markup
AlexeySachkov
approved these changes
Feb 7, 2025
Contributor
Author
|
Had to alter the compilation command within 2 tests because they fail when multiple triples were selected. Checked here: https://github.com/intel/llvm/actions/runs/13203760519/job/36861895735 For the bits wrapped in
|
aelovikov-intel
approved these changes
Feb 7, 2025
uditagarwal97
approved these changes
Feb 10, 2025
Contributor
Author
|
@intel/bindless-images-reviewers @intel/syclcompat-lib-reviewers friendly ping. Progress on #16813 is dependent on these changes. |
DBDuncan
approved these changes
Feb 10, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
target-features is preferable for%ifstatements because this feature will only evaluate to true if a device with the corresponding build target is selected, or if we are inbuild-onlyand the corresponding triple was selected to build for the test.any-device-ison the other hand evaluates to true any time we have the device available on the system, even if it is marked as XFAIL/UNSUPPORTED, and onbuild-onlyit is never true because we have no devices in that mode.