Skip to content

Conversation

@ayylol
Copy link
Contributor

@ayylol ayylol commented Feb 4, 2025

Using target- features is preferable for %if statements because this feature will only evaluate to true if a device with the corresponding build target is selected, or if we are in build-only and the corresponding triple was selected to build for the test. any-device-is on the other hand evaluates to true any time we have the device available on the system, even if it is marked as XFAIL/UNSUPPORTED, and on build-only it is never true because we have no devices in that mode.

@ayylol ayylol requested review from a team as code owners February 4, 2025 21:55
@ayylol ayylol requested a review from uditagarwal97 February 4, 2025 21:55
@ayylol ayylol changed the title [SYCL][E2E] Repace any-device-is- with target- features in %if markup [SYCL][E2E] Repace any-device-is- with target- features in %if markup Feb 4, 2025
@ayylol ayylol changed the title [SYCL][E2E] Repace any-device-is- with target- features in %if markup [SYCL][E2E] Replace any-device-is- with target- features in %if markup Feb 4, 2025
@ayylol
Copy link
Contributor Author

ayylol commented Feb 7, 2025

Had to alter the compilation command within 2 tests because they fail when multiple triples were selected. Checked here: https://github.com/intel/llvm/actions/runs/13203760519/job/36861895735

For the bits wrapped in %if target-nvidia:

  • DeviceLib/cmath_test.cpp -> Fails to build for spir64, so I'm using %clangxx and setting the triple explicitly instead.
  • USM/P2P/p2p_atomics.cpp -> If multiple triples are selected we need to specify the triple in -Xsycl-target-backend that we are passing the options to.

@ayylol
Copy link
Contributor Author

ayylol commented Feb 10, 2025

@intel/bindless-images-reviewers @intel/syclcompat-lib-reviewers friendly ping. Progress on #16813 is dependent on these changes.

@ayylol
Copy link
Contributor Author

ayylol commented Feb 10, 2025

@intel/llvm-gatekeepers This is ready to merge. Arc failure is #16877, and I opened #16949 for the PVC failure (This PR changes individual tests, and it doesn't touch that test).

@sarnex sarnex merged commit 5b292cd into intel:sycl Feb 10, 2025
14 of 16 checks passed
@ayylol ayylol deleted the if-directives branch February 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants