-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL][E2E] Mark non spir build targets as unsupported in AddressSanitizer tests #16886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note for reviewers, a majority of asan tests were never built for non-spir triples, but from my testing they are able to compile fine for nvptx other than the two tests changed in this pr. I'm doing this to enable prebuilt e2e testing on nvidia for precommit ci #16813. It's likely that more markup will be needed to disable the other triples for these tests, once I work on enabling prebuilt e2e testing for AMD, but I just wanted to do the smallest needed changes here. |
|
Hi @ayylol, although these tests can be built on cuda or amd, we don't have plan to support them. |
|
Hi @AllanZyne,
Yes, that's right they are currently skipped in the precommit ci for nvidia/amd. However the changes im trying to do is enabling nvidia for the
Would it be preferable then to disable all of these for the non-spir triples? I can add the |
target-spir in two Address Sanitizer tests that fail to build for nvptxtarget-spir in AddressSanitizer tests
Ok, I see.
Yep, it would be better to disable all for the non-spir triples. Thanks. |
target-spir in AddressSanitizer tests
No description provided.