[SYCL][E2E] Fix DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
#16664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Jan 16, 2025
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 | ||
| // Test flakily fails on PVC + OpenCL | ||
| // UNSUPPORTED: arch-intel_gpu_pvc && opencl | ||
| // UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/16662 |
Contributor
There was a problem hiding this comment.
I suggest we immediately fix the test instead: I believe that .wait() is missing on the actual kernel which fills result and since result is not a buffer which blocks on destruction to wait for all accessors using it we sometimes use it too early, i.e. before kernel has even completed/started.
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
changed the title
DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp as it is flakyDeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Jan 16, 2025
bader
reviewed
Jan 16, 2025
| // if adding new test here, don't forget to increment result's index | ||
| // and value of N variable | ||
| }); | ||
| }).wait(); |
Contributor
There was a problem hiding this comment.
The test must fee result memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16662
Add missing
.wait()afterqueue.submit().