[SYCLCompat] Fix vectorized_binary impl to make SYCLomatic migrated code run pass

[zhiweij1]

Signed-off-by: Jiang, Zhiwei [email protected]

[joeatodd]

Hey @zhiweij1 looks good! I understand now that you are altering the semantics of vectorized_binary for comparison operators by specifying the template argument (e.g. std::equal_to<unsigned short> vs std::equal_to<>). I think we misunderstood this previously. Can I suggest the following addition to sycl/doc/syclcompat/README.md after line 2091:

`vectorized_binary` also supports comparison operators from the standard library (`std::equal_to`, `std::not_equal_to`, etc) 
and the semantics can be modified by changing the comparison operator template instantiation. For example:

```cpp
unsigned int Input1;
unsigned int Input2;
// initialize inputs...

// Performs comparison on sycl::ushort2, following sycl::vec semantics
// Returns unsigned int containing, per vector element, 0xFFFF if true, and 0x0000 if false
syclcompat::vectorized_binary<sycl::ushort2>(
      Input1, Input2, std::equal_to<>());

// Performs element-wise comparison on unsigned short
// Returns unsigned int containing, per vector element, 1 if true, and 0 if false
syclcompat::vectorized_binary<sycl::ushort2>(
      Input1, Input2, std::equal_to<unsigned short>());

[zhiweij1]

Hey @zhiweij1 looks good! I understand now that you are altering the semantics of vectorized_binary for comparison operators by specifying the template argument (e.g. std::equal_to<unsigned short> vs std::equal_to<>). I think we misunderstood this previously. Can I suggest the following addition to sycl/doc/syclcompat/README.md after line 2091:

`vectorized_binary` also supports comparison operators from the standard library (`std::equal_to`, `std::not_equal_to`, etc) 
and the semantics can be modified by changing the comparison operator template instantiation. For example:

```cpp
unsigned int Input1;
unsigned int Input2;
// initialize inputs...

// Performs comparison on sycl::ushort2, following sycl::vec semantics
// Returns unsigned int containing, per vector element, 0xFFFF if true, and 0x0000 if false
syclcompat::vectorized_binary<sycl::ushort2>(
      Input1, Input2, std::equal_to<>());

// Performs element-wise comparison on unsigned short
// Returns unsigned int containing, per vector element, 1 if true, and 0 if false
syclcompat::vectorized_binary<sycl::ushort2>(
      Input1, Input2, std::equal_to<unsigned short>());

Done in c7b27d3

[zhiweij1]

@joeatodd Before adjusting the doc file, the CI has passed. So I think the failure in the latest CI is not related to this PR.

[joeatodd]

LGTM thanks @zhiweij1

[joeatodd]

@intel/llvm-gatekeepers this is ready to merge 🙏 CI failures unrelated.