[SYCL][Graph] Fix dyn_cgf_accessor_spv.cpp Test #16295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The E2E SYCL-Graph test `Update/dyn_cgf_accessor_spv.cpp` checks
that after the first execution of the graph, the accessor referencing
`bufferB` has not been written to. This is done by checking for zero
on the line
```cpp
assert(check_value(i, 0, HostDataB[i], "HostDataB"));
```
However, we never explicitly initialize `bufferB` to zero in the test,
it is uninitialized. Therefore this check against zero is not correct.
Fixed the test by initializing the buffers to zero at the beginning of
the test.
fabiomestre
approved these changes
Dec 6, 2024
Contributor
Author
|
@intel/llvm-gatekeepers This is ready to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E SYCL-Graph test
Update/dyn_cgf_accessor_spv.cppchecks that after the first execution of the graph, the accessor referencingbufferBhas not been written to. This is done by checking for zero on the lineHowever, we never explicitly initialize
bufferBto zero in the test, it is still uninitialized at the point of this assert. Therefore this check against zero is based on UB. This patch fixes the test by initializing the buffers to zero at the beginning of the test.