[SYCL] Add Panther Lake H & U to sycl_ext_oneapi_device_architecture #16294
Conversation
This patch adds two new GPU architectures - Panther Lake H and Panther Lake U to sycl_ext_device_architecture extension. Some small required refactoring was also performed.
dm-vodopyanov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
| // SYCL::gen::resolveGenDevice(). | ||
| def : IntelTargetInfo<"intel_gpu_bmg_g21", Fp16Fp64Atomic64, Sg16_32>; | ||
| // | ||
| // TODO: instructions on how to get "???" values below are required. Currently |
There was a problem hiding this comment.
@jzc can you please add instructions here? If they are too big, they can be moved to sycl/doc/developer folder and referenced here.
There was a problem hiding this comment.
The easiest way is to run sycl-ls --verbose, but that requires you having the HW. Until you know the data, you can always register a target as not supporting anything.
There was a problem hiding this comment.
@jzc could you please add a doc and info about these new architectures in the separate upcoming PR?
dm-vodopyanov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dm-vodopyanov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dm-vodopyanov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
sycl/doc/UsersManual.md change looks good to me.
| __SYCL_ARCHITECTURE_ALIAS(intel_gpu_20_4_4, intel_gpu_lnl_m) | ||
| __SYCL_ARCHITECTURE_ALIAS(intel_gpu_20_4_4, intel_gpu_lnl_m) | ||
| __SYCL_ARCHITECTURE_ALIAS(intel_gpu_30_0_4, intel_gpu_ptl_h) | ||
| __SYCL_ARCHITECTURE_ALIAS(intel_gpu_30_1_1, intel_gpu_ptl_u) |
There was a problem hiding this comment.
| __SYCL_ARCHITECTURE_ALIAS(intel_gpu_30_1_1, intel_gpu_ptl_u) | |
| __SYCL_ARCHITECTURE_ALIAS(intel_gpu_30_1_1, intel_gpu_ptl_u) | |
|
@uditagarwal97, @intel/llvm-reviewers-runtime, could you please take a look? |
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM! Given the urgency of this, could you please address @bader's comment in a follow-up? Comment doesn't seem to be a regression.
6 participants
This patch adds two new GPU architectures - Panther Lake H and Panther Lake U to sycl_ext_device_architecture extension.
Some small required NFC refactoring was also performed.