-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Implement restrict kernel argument property #16090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 3 commits into
intel:sycl
from
steffenlarsen:steffen/restrict_args
Dec 10, 2024
Merged
[SYCL] Implement restrict kernel argument property #16090
steffenlarsen
merged 3 commits into
intel:sycl
from
steffenlarsen:steffen/restrict_args
Dec 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the restrict property for annotated_arg and annotated_ptr, as specified in sycl_ext_oneapi_kernel_arg_properties. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
premanandrao
approved these changes
Nov 15, 2024
Contributor
premanandrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE changes LGTM
cperkinsintel
approved these changes
Dec 6, 2024
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Dec 10, 2024
This commit fixes an overly strict expectation in both restrict.cpp tests introduced in intel#16090. Signed-off-by: Larsen, Steffen <[email protected]>
Contributor
Author
|
Post-commit failure seems to be due to an overly strict expectation in the device-code tests. #16315 should address it. |
steffenlarsen
added a commit
that referenced
this pull request
Dec 10, 2024
This commit fixes an overly strict expectation in both restrict.cpp tests introduced in #16090. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the restrict property for annotated_arg and annotated_ptr, as specified in sycl_ext_oneapi_kernel_arg_properties.