Skip to content

Conversation

@dyniols
Copy link
Contributor

@dyniols dyniols commented Nov 5, 2024

Based on the test plan #15509, this PR adds an e2e test that performs following checks:

  • A check should be performed that we can successfully perform and immediately release a valid reservation of virtual memory.
  • A check should be performed that methods get_context(), get_device() and size() return correct values (i.e. ones which were passed to physical_mem constructor).
  • A check should be performed that a value returned from a valid call to map() is the same as reinterpret_cast<void *>(ptr).
  • A check should be performed that we can change access mode of a virtual memory range and immediately see it changed.
  • A check should be performed that we can successfully map and immediately unmap a virtual memory range.

@dyniols dyniols marked this pull request as ready for review November 5, 2024 14:40
@dyniols dyniols requested a review from a team as a code owner November 5, 2024 14:40
@dyniols dyniols requested a review from maarquitos14 November 5, 2024 14:40
@dyniols
Copy link
Contributor Author

dyniols commented Nov 7, 2024

@maarquitos14 Could you review this PR?

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

@dyniols
Copy link
Contributor Author

dyniols commented Nov 7, 2024

@intel/llvm-gatekeepers Can we merge it?

@sarnex
Copy link
Contributor

sarnex commented Nov 7, 2024

we should wait until CI finishes

@steffenlarsen steffenlarsen merged commit 4bca246 into intel:sycl Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants