[SYCL] Move XFAIL tracker checker test to compile-time #15832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
uditagarwal97
approved these changes
Oct 23, 2024
AlexeySachkov
approved these changes
Oct 23, 2024
|
Also tagging @KornevNikita: once we have similar thing for |
|
Merging now since build passed on linux and the test doesn't run on windows, and I don't want to have to rebase this thing constantly. |
|
@sarnex also thought about this, thanks! |
|
Would it also make sense to move the |
|
@ayylol im literally already doing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have all the info at compile time, no need to run this on a device every time.
Note the directory is moved from
test-e2etotest, it's hard to see in the github UI.We can drop the
--excludesince the test isn't in the same folder anymore.Using
../is a little gross, but it's worth it to save the resources of running E2E tests multiple times trying to fix failures in this test.Also manually tested that changing the XFAIL number causes the test to fail in
check-sycl.