[SYCL] Fix platform selection in opencl-aot #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before picking a matched platform name, ensure the device type also matches. This fixes a mismatch issue that was caused by an identical supported platform name for CPU and GPU. Only iterate through available platforms. When the error message is non-empty, always return CLErr, so that the message is shown. Signed-off-by: Dmitri Mokhov <[email protected]>
dm-vodopyanov
previously approved these changes
Apr 13, 2020
Signed-off-by: Dmitri Mokhov <[email protected]>
…nstructor. Signed-off-by: Dmitri Mokhov <[email protected]>
dm-vodopyanov
requested changes
Apr 15, 2020
Signed-off-by: Dmitri Mokhov <[email protected]>
Signed-off-by: Mokhov, Dmitri N <[email protected]>
dm-vodopyanov
previously approved these changes
Apr 17, 2020
Contributor
dm-vodopyanov
left a comment
dm-vodopyanov
left a comment
There was a problem hiding this comment.
As a suggestion for clear UX, ErrorMessage from getOpenCLDevice(Platform, Type) should be extended with something like Failed to find OpenCL ### device in these OpenCL platforms: ***, where ### could be CPU, ..., etc, and *** is the content of DeviceTypesToSupportedPlatformNames[Type] vector.
Signed-off-by: Mokhov, Dmitri N <[email protected]>
Signed-off-by: Mokhov, Dmitri N <[email protected]>
dm-vodopyanov
approved these changes
Apr 17, 2020
romanovvlad
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before picking a matched platform name, ensure the device type also
matches. This fixes a mismatch issue that was caused by an identical
supported platform name for CPU and GPU.
Only iterate through available platforms. When the error message is
non-empty, always return CLErr, so that the message is shown.
Signed-off-by: Dmitri Mokhov [email protected]