Skip to content

[CI][BuildBot] Fix configure parameter to turn on/off assertions #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2020
Merged

[CI][BuildBot] Fix configure parameter to turn on/off assertions #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c50487
[CI][BuildBot] Fix configure parameter to turn on/off assertions
bader Apr 1, 2020
e5620e1
Update linux_post_commit.yml
bader Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/linux_post_commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
config: ["Default", "SharedLibs", "Assertions"]
config: ["Default", "SharedLibs", "NoAssertions"]

steps:
- uses: actions/checkout@v2
Expand All @@ -28,8 +28,8 @@ jobs:
SharedLibs)
export ARGS="--shared-libs"
;;
Assertiosn)
export ARGS="--assertions"
NoAssertions)
export ARGS="--no-assertions"
;;
esac
mkdir -p $GITHUB_WORKSPACE/build
Expand Down
6 changes: 3 additions & 3 deletions buildbot/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ def do_configure(args):
libclc_targets_to_build = 'nvptx64--;nvptx64--nvidiacl'
sycl_build_pi_cuda = 'ON'

if args.assertions:
llvm_enable_assertions = 'ON'
if args.no_assertions:
llvm_enable_assertions = 'OFF'

if args.docs:
llvm_enable_doxygen = 'ON'
Expand Down Expand Up @@ -118,7 +118,7 @@ def main():
parser.add_argument("-t", "--build-type",
metavar="BUILD_TYPE", required=True, help="build type, debug or release")
parser.add_argument("--cuda", action='store_true', help="switch from OpenCL to CUDA")
parser.add_argument("--assertions", action='store_true', help="build with assertions")
parser.add_argument("--no-assertions", action='store_true', help="build without assertions")
parser.add_argument("--docs", action='store_true', help="build Doxygen documentation")
parser.add_argument("--no-ocl", action='store_true', help="download OpenCL deps via CMake")
parser.add_argument("--shared-libs", action='store_true', help="Build shared libraries")
Expand Down