Skip to content

Conversation

Ruyk
Copy link

@Ruyk Ruyk commented Mar 25, 2020

Adding doxygen documentation to PI CUDA backend.
Some code is re-ordered in the file to help sorting the doxygen.

@Ruyk Ruyk requested review from bader and sergey-semenov March 25, 2020 15:54
@bader bader added the cuda CUDA back-end label Mar 26, 2020
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be /// to align with the rest of project?

romanovvlad
romanovvlad previously approved these changes Mar 27, 2020
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @alexbatashev are you OK with the patch?

alexbatashev
alexbatashev previously approved these changes Mar 27, 2020
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please, sign-off your commits

Adding doxygen documentation to PI CUDA backend.
Some code is re-ordered in the file to help sorting the
doxygen.

Co-Authored-By: Alexey Bader <[email protected]>
Co-Authored-By: Alexander Batashev <[email protected]>
Co-Authored-By: Romanov Vlad <[email protected]>

Signed-off-by: Ruyman Reyes <[email protected]>
@bader bader merged commit 9be1566 into intel:sycl Mar 27, 2020
@Ruyk Ruyk deleted the pi-doxygen branch March 28, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda CUDA back-end

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants