Skip to content

[SYCL] Drop sycl/ext/oneapi/functional.hpp include from sycl/sub_group.hpp #13760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

[SYCL] Drop sycl/ext/oneapi/functional.hpp include from sycl/sub_group.hpp #13760

merged 1 commit into from
Jul 8, 2024

Conversation

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented May 10, 2024

Not needed anymore after deprecated shuffles/collectives were removed.

@aelovikov-intel aelovikov-intel mentioned this pull request May 20, 2024
Merged
@aelovikov-intel aelovikov-intel mentioned this pull request May 23, 2024
Merged
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request May 23, 2024
@aelovikov-intel
[SYCL] Delay inclusion of sycl/types.hpp in core.hpp
2e396bd 
Can't eliminate it completely until
intel#13760 is merged, but this PR brings
us closer to that goal.
aelovikov-intel added a commit that referenced this pull request May 27, 2024
@aelovikov-intel
[SYCL] Delay inclusion of sycl/types.hpp in core.hpp (#13902)
c275619 
Can't eliminate it completely until
#13760 is merged, but this PR brings
us closer to that goal.
@aelovikov-intel aelovikov-intel marked this pull request as ready for review June 28, 2024 15:48
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 28, 2024 15:48
@aelovikov-intel aelovikov-intel marked this pull request as draft June 28, 2024 19:10
@aelovikov-intel
[SYCL] Drop sycl/ext/oneapi/functional.hpp include from `sycl/sub_g…
903ac62 
…roup.hpp`

Not needed anymore after deprecated shuffles/collectives were removed. I
had to remove usage of `assert` from `sub_group`'s `load`/`store`
methods to avoid the last dependency on `sycl/builtins.hpp` from
`sycl/detail/core.hpp`. That should be fine for two reasons:

1) These are extension methods and not part of the SYCL 2020
2) `assert` support isn't universal on devices anyway, and fallback
support is expensive and is disabled by default, so we are not using
them in device code generally.
@aelovikov-intel aelovikov-intel marked this pull request as ready for review July 2, 2024 23:50
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Jul 8, 2024

Ping

@dm-vodopyanov dm-vodopyanov merged commit 4ab1e4b into intel:sycl Jul 8, 2024
@aelovikov-intel aelovikov-intel deleted the core-no-functional branch July 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aelovikov-intel @dm-vodopyanov