[CMake] Bump required CMake version to 3.20.0 #13664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM requires CMake 3.20 and up, which is specified in all the "built in" LLVM projects. This change bumps the DPCPP/SYCL specific projects to match that version.
asudarsa
approved these changes
May 6, 2024
Contributor
asudarsa
left a comment
asudarsa
left a comment
There was a problem hiding this comment.
Changes look good. Thanks
victor-eds
approved these changes
May 6, 2024
Contributor
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
sycl-fusion change LGTM
cperkinsintel
approved these changes
May 7, 2024
Contributor
Author
|
@intel/llvm-gatekeepers please merge |
rafbiels
added a commit
to rafbiels/llvm
that referenced
this pull request
Mar 5, 2025
find_package(CUDA) is deprecated since CMake 3.10 and the functionality we need is provided by find_package(CUDAToolkit) since CMake 3.17. Thanks to SYCL configuration now requiring CMake >3.20 (intel#13664), we can rely on find_package(CUDAToolkit) to work in all setups. Remove the deprecated calls and replace them with the recommended one. Clean up all extra CMake code dealing with finding CUPTI as that is also no longer needed (partially thanks to intel#17272). Replace all variables from the old module with corresponding ones from the new one. This solves multiple issues with finding libraries, notably including the failure to find libcuda.so automatically on systems where the CUDA driver is not installed and only the toolkit is available. This is a reasonable use case for building DPC++ on a build machine without a GPU and distributing for use on GPU machines.
kbenzie
pushed a commit
that referenced
this pull request
Mar 12, 2025
…#17315) `find_package(CUDA)` is deprecated since CMake 3.10 and the functionality we need is provided by `find_package(CUDAToolkit)` since CMake 3.17. Thanks to SYCL configuration now requiring CMake >3.20 (#13664), we can rely on `find_package(CUDAToolkit)` working in all setups. Changes: * Remove the deprecated calls and replace them with the recommended one. * Clean up all extra CMake code dealing with finding CUPTI as that is also now handled correctly by the FindCUDAToolkit module. * Replace all variables from the old module with corresponding ones from the new one, where they differ. * Update documentation on specifying custom CUDA installation path. This solves multiple issues with finding libraries, notably including the failure to find libcuda.so automatically on systems where the CUDA driver is not installed and only the toolkit is available. This is a reasonable use case for building DPC++ on a build machine without a GPU and distributing for use on GPU machines (easybuilders/easybuild-easyconfigs#22418 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM requires CMake 3.20 and up, which is specified in all the "built in" LLVM projects. This change bumps the DPCPP/SYCL specific projects to match that version.