[SYCL] Mark calls to barrier and work-item functions as convergent #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This patch doesn't solve the problem for PTX target (which is discussed in #1279). Because in this case spirv call is lowered to llvm.nvvm.barrier call which has convergent attribute. |
againull
requested review from
bader and
kbobrovs
and removed request for
kbobrovs
Calls to work-item functions and barrier function must be convergent to preserve semantics of these functions during llvm optimizations. Signed-off-by: Artur Gainullin <[email protected]>
bader
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to work-item functions and barrier function must be convergent to
preserve semantics of these functions during llvm optimizations.
Signed-off-by: Artur Gainullin [email protected]