[SYCL][XPTI] 'queue_id' metadata feature refactoring #13070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tovinkere
commented
Mar 20, 2024
tovinkere
commented
- Better requirements/test cases showed gaps in previous implementation that resulted in data inconsistencies
- Metadata is associated with UID and since UIDs are the same multiple instantiations of the same object, only invariant data needs to be stored in the metadata object
- Adding mutable data resulted in data inconsistencies and the feature refactoring addresses these issues
+ Better requirements/test cases showed gaps in current
implementation due to data inconsistencies
+ Metadata is associated with UID and since UIDs are the
same multiple instantiations of the same object, only
invariant data needs to be stored in the metadata object
+ Adding mutable data resulted in data inconsistencies
and the feature refactoring addresses these issues
Signed-off-by: Vasanth Tovinkere <[email protected]>
+ Added minor improvements regarding the mutable metadata
Key being global so the const char * pointer never goes
stale
Signed-off-by: Vasanth Tovinkere <[email protected]>
sycl/unittests/xpti_trace/xptitest_subscriber/XPTISubscriber.cpp
Outdated
Show resolved
Hide resolved
+ Fixed test framework to use the new API to get the data Signed-off-by: Vasanth Tovinkere <[email protected]>
Signed-off-by: Vasanth Tovinkere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.