[UR][CL] Gracefully tear down adapter in case that some globals were released #12992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… been released UR Part: oneapi-src/unified-runtime#1431
kbenzie
changed the title
kbenzie
reviewed
Mar 13, 2024
There was a problem hiding this comment.
oneapi-src/unified-runtime#1431 has now been merged, please pull in the latest changes from the sycl branch, fix the merge conflict, then apply the UR repo/tag changes as suggested then make this PR ready to review. Once this is down we'll get this approve so it can be merge.
Comment on lines
59
to
60
| set(UNIFIED_RUNTIME_REPO "https://github.com/zhaomaosu/unified-runtime.git") | ||
| set(UNIFIED_RUNTIME_TAG fix-ocl-adapter-tear-down) |
There was a problem hiding this comment.
Suggested change
| set(UNIFIED_RUNTIME_REPO "https://github.com/zhaomaosu/unified-runtime.git") | |
| set(UNIFIED_RUNTIME_TAG fix-ocl-adapter-tear-down) | |
| set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") | |
| # commit d99d5f742cea18d7204c59c4320b8ea0329b49eb | |
| # Merge: f17c0e91 c3809c61 | |
| # Author: Kenneth Benzie (Benie) <[email protected]> | |
| # Date: Wed Mar 13 19:47:39 2024 +0000 | |
| # Merge pull request #1431 from zhaomaosu/fix-ocl-adapter-tear-down | |
| # [CL] Gracefully tear down adapter in case that some globals have been released | |
| set(UNIFIED_RUNTIME_TAG d99d5f742cea18d7204c59c4320b8ea0329b49eb) |
aarongreig
approved these changes
Mar 14, 2024
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR Part: oneapi-src/unified-runtime#1431
Depends on #12736 merging first.