Skip to content

Conversation

keyradical
Copy link
Contributor

@keyradical keyradical commented Feb 21, 2024

@keyradical
Copy link
Contributor Author

Doesn't seem like the CI failures are related to this fix

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneapi-src/unified-runtime#1368 has been merged, however this PR is now dependent #12833 merging first. Once the dependent PR has merged please merge in the latest sycl branch changes, update the UR repo/tag, then make this PR ready for review.

@keyradical keyradical marked this pull request as ready for review March 13, 2024 12:49
@keyradical keyradical requested a review from a team as a code owner March 13, 2024 12:49
@kbenzie
Copy link
Contributor

kbenzie commented Mar 13, 2024

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 76789c8 into intel:sycl Mar 13, 2024
bader pushed a commit that referenced this pull request Mar 13, 2024
Mipmap interop:
 - Remove "interop" image type as it is redundant for image creation
 - Add a vulkan mipmap interop test

Slight redesign:
 - Simplify external resources

Modify the bindless spec to reflect these changes

Fix Vulkan interop tests to prevent memory leak issue by freeing mapped
memory

Corresponding UR PR:
oneapi-src/unified-runtime#1351

Depends on #12784 merging first

---------

Co-authored-by: DBDuncan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants