[SYCL] Adding versioninfo.rc to proxyloader.dll #12021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aelovikov-intel , no I did not know that we had that. Should we be using it? SYCL is using https://github.com/intel/llvm/blob/079fc97b51fe541ba5a4ba271bcc4dd6f43df21a/sycl/source/version.rc.in I'll try windows_version_resource.rc |
No idea, today was the first time I've seen any of this. |
…mplate provided by LLVM.
|
@aelovikov-intel - I dropped the source versioninfo.rc file and am using the the LLVM windows_versions_resource.rc file. I'm guessing that some of these other DLLs will need copyright info, so it'll be a better practice for us overall to use that common template rather than bespoke ones. |
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wangdi4
pushed a commit
to wangdi4/llvm
that referenced
this pull request
Dec 12, 2023
….dll (intel#12021) (intel#17939) Copyright declaration needed for 2024.1 https://jira.devtools.intel.com/browse/CMPLRLLVM-52451 Has been merged into xmain ( see intel-restricted/applications.compilers.llvm-project#17938 ) . Now this needs to be brought into the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copyright declaration needed for 2024.1