[SYCL][Bindless] Enable SPIRV path for bindless_images #11886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is 1st patch to enable SPIRV path for bindless_images so that we can start generating SPIRV for testing purpose.
przemektmalon
approved these changes
Nov 15, 2023
MrSidims
requested changes
Nov 15, 2023
isaacault
approved these changes
Nov 15, 2023
Seanst98
approved these changes
Nov 15, 2023
On windows we are getting _Z17__spirv_ImageReadIDv4_fyiET_T0_T1_ instead.
isaacault
approved these changes
Nov 16, 2023
MrSidims
approved these changes
Nov 16, 2023
againull
approved these changes
Nov 16, 2023
|
@intel/llvm-gatekeepers Can we get this merged? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 1st patch to enable SPIRV path for bindless_images so that we can start
generating SPIRV for testing purpose.