[SYCL] Include <complex>/<cmath> from sycl.hpp, unless SYCL2020_CONFORMANT_APIS #11326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RMANT_APIS intel#11274 and intel#11196 could break customers code that relied on implicit inclusion of those headers. Don't break it before the next ABI breaking window.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@steffenlarsen , your https://github.com/steffenlarsen/llvm/tree/steffen/sycl_preview_lib is still WIP so I'm using the old/current macro guard. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Strictly speaking, the cmath inclusion has no relation to SYCL 2020 conformance, apart from a nicer user experience after SYCL 2020 builtin refactoring. That said, I am okay with this as a stop-gap while we get the new preview option ready and potentially deprecate this macro anyway.
victor-eds
added a commit
to victor-eds/oneMKL
that referenced
this pull request
Sep 29, 2023
`onemkl_blas_portblas.hpp` was missing these headers. Note intel/llvm#11326 removed these headers from `<sycl/sycl.hpp>` by default. As `portBLAS` was the only backend not importing `<complex>` before the change, it's the only one reporting this issue. Signed-off-by: Victor Perez <[email protected]>
2 tasks
muhammad-tanvir-1211
pushed a commit
to uxlfoundation/oneMath
that referenced
this pull request
Oct 18, 2023
Note: intel/llvm#11326 removed these headers from `<sycl/sycl.hpp>` by default. As `portBLAS` was the only backend not importing `<complex>` before the change, it's the only one reporting this issue. Signed-off-by: Victor Perez <[email protected]>
aelovikov-intel
added a commit
that referenced
this pull request
Apr 1, 2024
Any user code relying on those included implicitly is wrong and we don't consider it a breaking change, just a bug fix. Reverts #11326. We agreed that this isn't an ABI break as the code relying on this wasn't standard conforming. However, ABI break is next week, so I'll be merging it then. Meanwhile, adding `abi-break` label to ease documentation update later.
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
…on#389) Note: intel/llvm#11326 removed these headers from `<sycl/sycl.hpp>` by default. As `portBLAS` was the only backend not importing `<complex>` before the change, it's the only one reporting this issue. Signed-off-by: Victor Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11274 and
#11196 could break customers code that relied on implicit inclusion of those headers. Don't break it before the next ABI breaking window.