[SYCL] Split build options into separate compile and link options #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the options described in s5.8.5 "Linker Options" of OpenCL 2.0 specification are supported by clLinkProgram. Since SYCL_PROGRAM_BUILD_OPTIONS environment variable and `pi_device_binary_struct.BuildOptions' may contain compile options (such as "-g"), we should not use it. Same applies for clCompileProgram and *link* options. This patch changes clang-offload-wrapper and SYCL runtime to maintain two distinct lists of options: one for compile (to use with clCompileProgram), and one for link (to use with clLinkProgram). It also replaces SYCL_PROGRAM_BUILD_OPTIONS environment variable with two separate variables: SYCL_PROGRAM_COMPILE_OPTIONS and SYCL_PROGRAM_LINK_OPTIONS. Signed-off-by: Andrew Savonichev <[email protected]>
bader
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the options described in s5.8.5 "Linker Options" of OpenCL 2.0
specification are supported by clLinkProgram. Since
SYCL_PROGRAM_BUILD_OPTIONS environment variable and
`pi_device_binary_struct.BuildOptions' may contain compile
options (such as "-g"), we should not use it.
Same applies for clCompileProgram and link options.
This patch changes clang-offload-wrapper and SYCL runtime to maintain
two distinct lists of options: one for compile (to use with
clCompileProgram), and one for link (to use with clLinkProgram).
It also replaces SYCL_PROGRAM_BUILD_OPTIONS environment variable with
two separate variables: SYCL_PROGRAM_COMPILE_OPTIONS and
SYCL_PROGRAM_LINK_OPTIONS.
Signed-off-by: Andrew Savonichev [email protected]