Skip to content

[SYCL][HIP] Fix libclc typo #10657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

[SYCL][HIP] Fix libclc typo #10657

merged 1 commit into from
Aug 14, 2023

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Aug 2, 2023

A small part of #10656 that can be cherry picked more easily

@hdelan hdelan requested a review from a team as a code owner August 2, 2023 11:45
@hdelan hdelan requested a review from npmiller August 2, 2023 11:45
@hdelan hdelan temporarily deployed to aws August 2, 2023 12:08 — with GitHub Actions Inactive
@hdelan hdelan temporarily deployed to aws August 2, 2023 12:54 — with GitHub Actions Inactive
jchlanda
jchlanda approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's derived from sycl::logical_or's identity value, right?

@jchlanda jchlanda mentioned this pull request Aug 3, 2023
Merged
@hdelan
Copy link
Contributor Author

hdelan commented Aug 3, 2023

It's the identity of __CLC_OR(x, y) \ (x | y) https://github.com/intel/llvm/pull/10657/files#diff-af4a8864fc0a12205d3cd8f94b836949ff08a0df152832fc1ba2755f552e1453R66

@hdelan hdelan closed this Aug 3, 2023
@hdelan hdelan reopened this Aug 3, 2023
@hdelan hdelan temporarily deployed to aws August 3, 2023 09:40 — with GitHub Actions Inactive
@hdelan hdelan temporarily deployed to aws August 3, 2023 10:28 — with GitHub Actions Inactive
@hdelan
Copy link
Contributor Author

hdelan commented Aug 14, 2023

Also requested for review here @npmiller 😸 , @intel/llvm-gatekeepers this is quite self contained, can it be merged?

@aelovikov-intel aelovikov-intel merged commit 3f3df77 into intel:sycl Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchlanda jchlanda jchlanda approved these changes

@npmiller npmiller Awaiting requested review from npmiller npmiller is a code owner automatically assigned from intel/llvm-reviewers-cuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdelan @jchlanda @aelovikov-intel