[SYCL] Set minimum required CMake version to 3.5. #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Lazarev <[email protected]>
romanovvlad
approved these changes
Apr 22, 2019
againull
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
I checked release notes of 3.5 release.
https://github.com/Kitware/CMake/releases/tag/v3.5.0
And this copy command is supported since 3.5 (documentation on the site is confusing).
So, changes are correct.
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
Oct 25, 2019
CONFLICT (content): Merge conflict in clang/lib/Sema/SemaOverload.cpp
vmaksimo
added a commit
to vmaksimo/llvm
that referenced
this pull request
Oct 6, 2020
CONFLICT (content): Merge conflict in clang/lib/Driver/ToolChains/Clang.cpp
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Dec 15, 2020
CONFLICT (content): Merge conflict in clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake copy operation (e.g. sycl/CMakeLists.txt:76) allows to copy multiple files starting from cmake 3.5.
Signed-off-by: Vladimir Lazarev [email protected]