This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Test printf with FP64 types only when available on target HW #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to placing the `double` tests under `aspect::fp64` checks, this commit accounts for the case where the compiler performs variadic argument promotion for the `float` type. Signed-off-by: Artem Gindinson <[email protected]>
AlexeySachkov
previously approved these changes
Jan 10, 2022
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
force-pushed
the
printf-fp64
branch
from
422fded to
992d94b
Compare
AlexeySachkov
approved these changes
Jan 10, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#715) In addition to placing the double tests under aspect::fp64 checks, this commit accounts for the case where the compiler performs variadic argument promotion for the float type. Signed-off-by: Artem Gindinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to placing the
doubletests underaspect::fp64checks,this commit accounts for the case where the compiler performs variadic
argument promotion for the
floattype.Signed-off-by: Artem Gindinson [email protected]