This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add an OpenCL function caching issue workaround to get_backend #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue with extension function pointer caching in OpenCL plugin: each extension function call helper keeps a pi_context-to-fptr map cache, however, these maps aren't cleaned up on context release. This can lead to the following situation: - Context A is created - An extension function is called in context A - Context A is destroyed - A new context B is created, which happens to have the same pi_context handle - A cached function is called If these two contexts have different platforms (like in get_backend test), this will lead to an error. This patch removes the use of USM functions from the test to circumvent this issue and reenable get_backend API testing.
Author
|
It seems that clang-format crashes because of the deletion of the first line in the file. If I recall correctly, this is a known problem. |
steffenlarsen
approved these changes
Jan 4, 2022
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
As a work-around this looks good to me. Should we have a comment about it being a work-around or should we keep it after the problem has been fixed and let another - more specialized - test handle the testing?
Author
|
Superseded by #745 & intel/llvm#5282 |
|
@s-kanaev, @sergey-semenov do we need this PR? If so could you please address the CI issue? |
|
@sergey-semenov, @s-kanaev, do we need this PR? |
|
Yes. This PR is needed. I'll handle CI failures. |
|
Moving to Draft until CI failure are fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with extension function pointer caching in OpenCL
plugin: each extension function call helper keeps a pi_context-to-fptr
map cache, however, these maps aren't cleaned up on context release. This
can lead to the following situation:
handle
If these two contexts have different platforms (like in get_backend
test), this will lead to an error. This patch removes the use of USM
functions from the test to circumvent this issue and reenable
get_backend API testing.