This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove more program class usages #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
requested review from
AGindinson,
AlexeySachkov,
bader,
dm-vodopyanov,
kbobrovs,
romanovvlad,
v-klochkov,
vladimirlaz and
a team
as code owners
kbobrovs
reviewed
Oct 12, 2021
| @@ -0,0 +1,207 @@ | |||
| //==--------------- histogram_256_slm.cpp - DPC++ ESIMD on-device test ----==// | |||
There was a problem hiding this comment.
- The test path should have esimd somewhere (DeprecatedFeatures/esimd?)
- As I see, SYCL/ESIMD/mandelbrot/mandelbrot_spec.cpp was fixed in this PR to use 2020 spec constants, can the same be done for other tests (e.g. this one)?
There was a problem hiding this comment.
The test path should have esimd somewhere (DeprecatedFeatures/esimd?)
Fixed
can the same be done for other tests (e.g. this one)?
I'm not sure. Some tests have a SYCL 2020 version (like this one), and others don't, and I don't see any pattern here.
vladimirlaz
previously approved these changes
Oct 12, 2021
added 2 commits
October 12, 2021 15:32
kbobrovs
previously approved these changes
Oct 13, 2021
kbobrovs
reviewed
Oct 13, 2021
Not sure what you mean. If you're talking about histogram test, there's a very similar test with SYCL2020 APIs. For others - we're removing program class completely, so there's no option to leave everything as is. Tests won't work. |
AlexeySachkov
approved these changes
Oct 15, 2021
romanovvlad
approved these changes
Oct 15, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.